kernel/sched: Panic on aborting essential threads #45813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Documentation specifies that aborting/terminating/exiting essential threads is a system panic condition, but we didn't actually implement that and allowed it as for other threads. At least one app wants to exploit this documented behavior as a "watchdog" kind of condition, and that seems reasonable. Do what we say we're supposed to do. This also includes a small fix to a test, which seemed like it was written to exercise exactly this condition. Except that it failed to detect whether or not a system fatal error was actually signaled and was (incorrectly) indicating "success". Check that we actually enter the handler. Fixes zephyrproject-rtos#45545 Signed-off-by: Andy Ross <[email protected]>
github-actions
bot
added
area: Kernel
area: Tests
dcpleung
previously approved these changes
May 19, 2022
teburd
previously approved these changes
May 19, 2022
This test was written to do a k_oops() in the main thread. That's an essential thread, and aborting it is actually a system panic now. The test was written contra the docs on this, but it worked fine for years. Just reflag the thread as a simple workaround rather than trying anything fancy. This is a very simple test. Signed-off-by: Andy Ross <[email protected]>
dcpleung
approved these changes
May 19, 2022
|
Had to sneak in one extra patch because it turns out we had a test case that was doing exactly what is now illegal (though even there it actually failed only on native_posix because of an oddball issue with the regex -- as I read it, it should have been "happy" with the panic instead of the oops even though that wasn't what it was looking for). |
teburd
approved these changes
May 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documentation specifies that aborting/terminating/exiting essential
threads is a system panic condition, but we didn't actually implement
that and allowed it as for other threads. At least one app wants to
exploit this documented behavior as a "watchdog" kind of condition,
and that seems reasonable. Do what we say we're supposed to do.
This also includes a small fix to a test, which seemed like it was
written to exercise exactly this condition. Except that it failed to
detect whether or not a system fatal error was actually signaled and
was (incorrectly) indicating "success". Check that we actually enter
the handler.
Fixes #45545
Signed-off-by: Andy Ross [email protected]