drivers/clock_control: stm32u5: Wrong bus check in _get_rate() #45822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erwango
requested review from
mbolivar-nordic,
MaureenHelm and
galak
as code owners
erwango
force-pushed
the
fix_u5_clock_device_test
branch
from
7bffe4a to
3b3e006
Compare
Already done on other driver variants. |
Checking that provided pclken->bus fits bus range in clock_control_get_rate() is wrong as it could actually be a source clock and hence not belong to this range. Also, this kind of check is just not needed since this function should not be used before call to clock_control_on() or clock_control_configure() which do the required verification. Signed-off-by: Erwan Gouriou <[email protected]>
erwango
force-pushed
the
fix_u5_clock_device_test
branch
from
3b3e006 to
d2bc33a
Compare
FRASTM
approved these changes
May 20, 2022
GeorgeCGV
approved these changes
May 23, 2022
GeorgeCGV
approved these changes
May 23, 2022
MaureenHelm
approved these changes
May 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checking that provided pclken->bus fits bus range in
clock_control_get_rate() is wrong as it could actually be a source
clock and hence not belong to this range.
Also, this kind of check is just not needed since this function should
not be used before call to clock_control_on() or clock_control_configure()
which do the required verification.
Fixes #45821
Signed-off-by: Erwan Gouriou [email protected]