Bluetooth: Controller: df: Fix possible memory overwrite if requested number of CTE is greater than allowed by configuration #45838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maximum number of CTE to be send in a periodic advertising chain is limited by BT 5.3 Vol 4 Part E, section 7.8.80 and is 16. Maximum number of samples CTE in a periodic advertising chain is limited by BT 5.3 Vol 4 Part E, section 7.8.82 and is also 16. Both values are limited by amount of memory reserved in Controller by Kcofigs, respectfully: CONFIG_BT_CTLR_DF_PER_ADV_CTE_NUM_MAX and CONFIG_BT_CTLR_DF_PER_SCAN_CTE_NUM_MAX. Functions ll_df_set_cl_cte_tx_params and ll_df_set_cl_iq_sampling_enable check limits against Bluetooth specification provided values. That can end with memory overwrite if number of requested CTEs is greater that number provided in configuration. The commit changes mentioned functions to validate HCI commands parameters against configuration values. Signed-off-by: Piotr Pryga <[email protected]>
ppryga-nordic
requested review from
carlescufi,
cvinayak,
thoh-ot and
kruithofa
as code owners
cvinayak
approved these changes
May 20, 2022
kruithofa
approved these changes
May 25, 2022
ppryga-nordic
deleted the
github-ble-df-fix-req-cte-num-check-in-connectionless-mode
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maximum number of CTE to be send in a periodic advertising chain is
limited by BT 5.3 Vol 4 Part E, section 7.8.80 and is 16.
Maximum number of samples CTE in a periodic advertising chain is
limited by BT 5.3 Vol 4 Part E, section 7.8.82 and is also 16.
Both values are limited by amount of memory reserved in Controller
by Kcofigs, respectfully: CONFIG_BT_CTLR_DF_PER_ADV_CTE_NUM_MAX and
CONFIG_BT_CTLR_DF_PER_SCAN_CTE_NUM_MAX.
Functions ll_df_set_cl_cte_tx_params and ll_df_set_cl_iq_sampling_enable
check limits against Bluetooth specification provided values.
That can end with memory overwrite if number of requested CTEs is
greater that number provided in configuration.
The commit changes mentioned functions to validate HCI commands
parameters against configuration values.
Signed-off-by: Piotr Pryga [email protected]