Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bluetooth: host: Revert "bluetooth: host: Avoid sending duplicate dev… #46505

Merged
merged 1 commit into from
Jun 17, 2022
Merged

bluetooth: host: Revert "bluetooth: host: Avoid sending duplicate dev… #46505

merged 1 commit into from
Jun 17, 2022

Conversation

ibaz-nordic
Copy link
Contributor

@ibaz-nordic ibaz-nordic commented Jun 14, 2022 •
edited by carlescufi
Loading

…ice to resolving list."

This reverts commit e11ff7d.
This patch causes some PTS failure (see #45510 (comment))
Another patch to address duplicate device will follow.

Fixes #46602.

@ibaz-nordic ibaz-nordic force-pushed the revert_rl branch 2 times, most recently from dfd8a35 to 0045918 Compare June 14, 2022 08:46
@ibaz-nordic ibaz-nordic mentioned this pull request Jun 14, 2022
Merged
@jori-nordic
Copy link
Collaborator

Can you add a comment referencing the PTS test(s) that are broken ?

@sjanc
Copy link
Collaborator

sjanc commented Jun 15, 2022

#AutoPTS run zephyr GAP/CONN/ACEP GAP/CONN/DCEP GAP/CONN/GCEP

@codecoup-tester
Copy link

Scheduled PR ##46505 (comment) after 10:26:19.

@carlescufi carlescufi mentioned this pull request Jun 16, 2022
Closed
carlescufi
carlescufi previously approved these changes Jun 16, 2022
View reviewed changes
@carlescufi
Copy link
Member

@sjanc are we waiting for an autopts run here?

@ibaz-nordic
bluetooth: host: Revert "Avoid sending duplicate device to resolving …
a0f9dc6 
…list."

This reverts commit e11ff7d.
This patch causes some PTS failure.
Another patch to address duplicate device will follow.

Signed-off-by: Azizah Ibrahim <[email protected]>
@sjanc
Copy link
Collaborator

sjanc commented Jun 17, 2022

yes, we were waiting but bot failed to report results to github :)

GAP GAP/CONN/ACEP/BV-01-C PTS TIMEOUT
GAP GAP/CONN/ACEP/BV-03-C PASS (progress)
GAP GAP/CONN/ACEP/BV-04-C PTS TIMEOUT
GAP GAP/CONN/DCEP/BV-01-C PTS TIMEOUT
GAP GAP/CONN/DCEP/BV-03-C PASS
GAP GAP/CONN/DCEP/BV-05-C PASS (progress)
GAP GAP/CONN/DCEP/BV-06-C PASS (progress)
GAP GAP/CONN/GCEP/BV-01-C PASS
GAP GAP/CONN/GCEP/BV-02-C PASS
GAP GAP/CONN/GCEP/BV-05-C PASS (progress)
GAP GAP/CONN/GCEP/BV-06-C PASS (progress)

@carlescufi carlescufi merged commit 2a175b6 into zephyrproject-rtos:main Jun 17, 2022
@Thalley Thalley mentioned this pull request Jun 24, 2022
Closed
@ibaz-nordic ibaz-nordic deleted the revert_rl branch October 20, 2022 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhedberg jhedberg jhedberg approved these changes

@sjanc sjanc sjanc approved these changes

@carlescufi carlescufi carlescufi approved these changes

@alwa-nordic alwa-nordic Awaiting requested review from alwa-nordic

@Vudentz Vudentz Awaiting requested review from Vudentz

@asbjornsabo asbjornsabo Awaiting requested review from asbjornsabo

@jori-nordic jori-nordic Awaiting requested review from jori-nordic

@Thalley Thalley Awaiting requested review from Thalley

Assignees

@jhedberg jhedberg

Labels
area: Bluetooth
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BLE paring/connection issue on Windows (Zephyr 3.1.0)
7 participants
@ibaz-nordic @jori-nordic @sjanc @codecoup-tester @carlescufi @jhedberg @zephyrbot