mgmt/hawkbit: Fix null pointer access #49232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ycsin
requested review from
Navin-Sankar,
nashif,
carlescufi,
galak and
MaureenHelm
as code owners
ycsin
force-pushed
the
pr/hawkbit_fix_null_links
branch
from
2392354 to
f28b8cf
Compare
ycsin
changed the title
|
Not sure how should I go about this, cc @nashif |
ycsin
force-pushed
the
pr/hawkbit_fix_null_links
branch
from
f28b8cf to
85d79a8
Compare
|
@gkujawsk @jeronimoagullo could you test if this PR fixes the issue that you encountered? |
ycsin
force-pushed
the
pr/hawkbit_fix_null_links
branch
from
85d79a8 to
c7c303a
Compare
ycsin
force-pushed
the
pr/hawkbit_fix_null_links
branch
from
c7c303a to
be9bc97
Compare
ycsin
changed the title
ycsin
force-pushed
the
pr/hawkbit_fix_null_links
branch
from
be9bc97 to
5ba810a
Compare
ycsin
force-pushed
the
pr/hawkbit_fix_null_links
branch
from
5ba810a to
f7b4367
Compare
ycsin
changed the title
If the is no update from the server, the _links will be NULL. Check if it is NULL before trying to LOG these strings. Signed-off-by: Yong Cong Sin <[email protected]>
ycsin
force-pushed
the
pr/hawkbit_fix_null_links
branch
from
f7b4367 to
590c8ca
Compare
carlescufi
approved these changes
Sep 19, 2022
|
@ycsin, I missed this before. |
sylvioalves
approved these changes
Sep 19, 2022
ycsin
added
bug
ycsin
added
backport v2.7-branch
This was referenced Sep 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pending testing and approval(s) by issue reporter(s)
Fixes #48863