[Backport v3.0-branch] twister: ignore serial device SerialException. #50682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some boards, like up_squared and ehl_crb, they need do a power off/on operation and use bios to load and execute zephyr test binary, during the power off, it may meet this SerialException, but the serial object still works well after power on, we can continue to get all results from serial, so we don't need to close it, it's ok to ignore this exception. BTW, even if we ignore this exception here, it doesn't influence twister function, because if it was really caused by disconnection, the test would still be judged as failed due to timeout and serial would be closed later in main thread, it doesn't impact results. On the contrary, close serial directly in the monitor serial thread, it will cause later tests failed due to mismatch errors. Signed-off-by: Chen Peng1 <[email protected]> (cherry picked from commit ca08d2e)
enjiamai
approved these changes
Sep 27, 2022
smrtos
approved these changes
Sep 27, 2022
dkalowsk
approved these changes
Nov 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport ca08d2e from #44976
Fixes #45009