lib: os: reboot: a few cleanups #60920
Conversation
gmarull
force-pushed
the
reboot-cleanup
branch
3 times, most recently
from
a61b8f3 to
4e3b7b9
Compare
|
The cleanup lgtm, however, I would put the fix for #60915 into its own PR |
gmarull
force-pushed
the
reboot-cleanup
branch
4 times, most recently
from
0855475 to
adfae6c
Compare
gmarull
force-pushed
the
reboot-cleanup
branch
2 times, most recently
from
3e3c0d6 to
2955328
Compare
gmarull
requested review from
nashif,
jfischer-no,
martinjaeger,
rlubos,
nandojve,
Navin-Sankar,
carlescufi,
de-nordic,
nordicjm,
henrikbrixandersen,
jhedberg,
Vudentz,
alwa-nordic,
sjanc,
microbuilder,
dcpleung,
andyross and
carlocaione
as code owners
62dbe72 introduced yet another reboot API for no reason. This patch converts the implementation into a sys_reboot() hook. Note that shell commands have been deleted, as there's already a shell command that uses the standard reboot. Signed-off-by: Gerard Marull-Paretas <[email protected]>
Add details on changes made in the reboot.h API. Signed-off-by: Gerard Marull-Paretas <[email protected]>
|
rebased to fix conflicts |
gmarull
dismissed stale reviews from nordicjm, manuargue, carlocaione, martinjaeger, and jfischer-no
via
7a969af
gmarull
requested review from
manuargue,
carlocaione,
jfischer-no,
nordicjm and
martinjaeger
|
so what is exactly blocking this PR now? |
Four days waiting and already inpatient. |
not impatient, just unsure on why it's being blocked. |
|
@gmarull I think I recall @nashif mentioning that this should go through the treewide process https://docs.zephyrproject.org/latest/contribute/guidelines.html#treewide-changes |
|
Closing this one, if someone else has an interest and patience in this, feel free to take it. |
|
It's a shame this very useful cleanup didn't make it in. @nashif It looks like your previous concern has been addressed. Is there still something else blocking? |
After 62dbe72 and discussions in #60626 I realized the reboot functionality required a bit of love. So I tried to clean up things a little bit. I may have made a few mistakes, so please, review. I tried to make changes in small steps to ease the review process.
Fixes #60915