drivers: auxdisplay: Add driver for common 7-segment display #68501

xingrz · 2024-02-03T12:31:15Z

This PR introduces a new driver for a common GPIO-driven 7-segment display. supporting both common anode and common cathode configurations.

It also includes a new sample demonstrates counting from 0 to 1000, with an interval of 100ms between each increment.

dts/bindings/auxdisplay/gpio-7-segment.yaml

thedjnK · 2024-02-07T20:58:26Z

drivers/auxdisplay/auxdisplay_gpio_7seg.c

+	struct auxdisplay_gpio_7seg_data *data = dev->data;
+	uint32_t ib, ic;
+
+	for (ib = 0, ic = 0; ib < cfg->digit_count && ic < len; ic++) {


For the other drivers, this always writes from the last position, whilst for a 7-segment display you might want (or expect) that, it deviates from the API:

* @brief Write data to auxiliary display screen at current position

What are your thoughts on adding position get/set and having write update the current character and advancing the position (also thinking this can be used on hex segment displays also)?

This is actually a consideration for handling decimal points. For example, if you want to display 10.3, the decimal point is the third character in the data. However, on a 7-segment display, it is part of the second digit (0). Therefore, I need to do some processing in the write function, so that when the current character is identified as '.', the decimal point of the previous digit is lit.

thedjnK · 2024-02-07T20:59:38Z

samples/drivers/auxdisplay_digits/src/main.c

+		return -ENODEV;
+	}
+
+	snprintk(data, sizeof(data), "8.8.8.");


Would be good if this sample adapted to the number of characters in the display

thedjnK · 2024-02-07T21:00:21Z

drivers/auxdisplay/auxdisplay_gpio_7seg.c

+	for (ib = 0, ic = 0; ib < cfg->digit_count && ic < len; ic++) {
+		if (ch[ic] >= '0' && ch[ic] <= '9') {
+			cfg->buffer[ib++] = DIGITS[ch[ic] - '0'];
+		} else if (ch[ic] == '.') {


This does not check that a dot segment is present

It's okay here since it's just setting the buffer bits and not actually updating the GPIOs directly. The DP bit will be ignored if only 7 GPIOs are present, as handled in the auxdisplay_gpio_7seg_timer_expiry_fn function below.

xingrz · 2024-03-19T15:04:03Z

Oh, wow! I have a new idea. Maybe I should separate this into an LED strip (or LED controller) driver, probably named "common-electrode-leds", and build the segment display driver on top of it. So, in theory, we could then drive any any-segment display with any form of multi-channel LED controller.

thedjnK · 2024-04-09T19:52:58Z

Oh, wow! I have a new idea. Maybe I should separate this into an LED strip (or LED controller) driver, probably named "common-electrode-leds", and build the segment display driver on top of it. So, in theory, we could then drive any any-segment display with any form of multi-channel LED controller.

It's an option. For LED displays they are usually numeric, alphanumeric or hex, so auxdisplay can work with all of those.

github-actions · 2024-06-09T00:31:09Z

This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time.

cfriedt · 2024-08-12T20:31:08Z

@xingrz - is there any chance that this could be reopened? I guess that this fell off the radar during the last release cycle.

I would be happy to re-review 😄

xingrz · 2024-08-13T03:17:57Z

@cfriedt Well, I’m not sure. I’m uncertain if this idea is fully developed. I’ve noticed that in actual projects, people often use dedicated LED driver ICs or GPIO expanders instead of the MCU’s GPIOs to drive the 7-segment displays. This approach provides enough driving power and minimizes IO usage. I think we should consider these scenarios, but I don’t have any concrete ideas yet. Let’s keep this PR closed for now. Perhaps in the future, someone interested might discover it and offer some new insights.

thedjnK · 2024-08-13T17:49:50Z

Port expanders are natively supported in zephyr through the GPIO interface so should be fine

cfriedt · 2024-08-13T23:39:47Z

I have a board in front of me that just uses GPIO as well without a driver. Depending on the brightness level required, I think it's reasonable in some circumstances.

thedjnK

Wasn't aware this got updated, minor change request for the binding compatible then looks good to go!

thedjnK · 2024-09-11T15:18:58Z

drivers/auxdisplay/auxdisplay_gpio_7seg.c

+ * SPDX-License-Identifier: Apache-2.0
+ */
+
+#define DT_DRV_COMPAT gpio_7_segment


should have zephyr prefix

thedjnK · 2024-09-11T15:19:10Z

dts/bindings/auxdisplay/gpio-7-segment.yaml

+          };
+  };
+
+compatible: "gpio-7-segment"


needs zephyr, prefix

github-actions · 2024-11-11T00:34:34Z

This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time.

cfriedt · 2024-11-12T03:07:52Z

This is so close to being done @xingrz

xingrz · 2024-11-12T10:33:33Z

@kartben Thanks for you suggestions.

Also rebased to include the build_all/auxdisplay changes.

decsny · 2024-11-12T12:15:47Z

dts/bindings/auxdisplay/zephyr,gpio-7-segment.yaml

+          };
+  };
+
+compatible: "zephyr,gpio-7-segment"


why put a zephyr, prefix if this binding is already based on linux ? why not just keep the linux compatible ?

No, it’s not based on Linux, and they are not compatible. This driver was introduced a few months before a similar one was added to the Linux kernel. It’s a completely different implementation, with additional features such as multi-digit support.

thedjnK · 2024-11-28T16:17:59Z

@xingrz would you be able to come back to this?

xingrz · 2024-11-28T16:55:37Z

Rebased to align with #82121.

Additionally, I added a native_sim target to the sample, ensuring it gets included in CI builds going forward.

drivers/auxdisplay/auxdisplay_gpio_7seg.c

kartben

Pending request for change re: README has actually not been addressed, sorry that I missed it earlier today

xingrz · 2024-11-29T02:48:12Z

Pending request for change re: README has actually not been addressed, sorry that I missed it earlier today

Apologies for missing that as well. I'll address it as soon as possible.

Request addressed

This commit introduces a new driver for a common GPIO-driven 7-segment display. supporting both common anode and common cathode configurations. Signed-off-by: Chen Xingyu <[email protected]>

This commit introduces a new sample for the Auxiliary display driver. The sample demonstrates counting from 0 to 1000, with an interval of 100ms between each increment. This sample primarily serves to demonstrate the capabilities of segment displays. Signed-off-by: Chen Xingyu <[email protected]>

xingrz · 2024-11-29T13:58:51Z

Rebased to include the recently merged DEVICE_API changes.

This PR is now ready for review.

thedjnK · 2024-12-01T09:28:55Z

@xingrz for future, when people should look at a review again they need to be requested, use the refresh icon next to each name in the reviewers list

xingrz force-pushed the auxdisplay-7seg/pr branch from 68be124 to 682a00d Compare February 3, 2024 12:39

xingrz marked this pull request as ready for review February 3, 2024 12:49

xingrz requested a review from thedjnK as a code owner February 3, 2024 12:49

zephyrbot added area: Devicetree Binding PR modifies or adds a Device Tree binding area: Samples Samples area: Aux display labels Feb 3, 2024

zephyrbot requested review from galak, kartben and nashif February 3, 2024 12:50

zephyrbot assigned thedjnK Feb 3, 2024

thedjnK reviewed Feb 7, 2024

View reviewed changes

xingrz force-pushed the auxdisplay-7seg/pr branch from 682a00d to 9a37357 Compare February 9, 2024 04:36

github-actions bot added the Stale label Jun 9, 2024

github-actions bot closed this Jun 24, 2024

simonguinot self-requested a review August 13, 2024 08:45

xingrz reopened this Aug 14, 2024

github-actions bot removed the Stale label Aug 15, 2024

thedjnK reviewed Sep 11, 2024

View reviewed changes

github-actions bot added the Stale label Nov 11, 2024

cfriedt removed the Stale label Nov 12, 2024

xingrz force-pushed the auxdisplay-7seg/pr branch from 9a37357 to 74228b0 Compare November 12, 2024 04:58

xingrz force-pushed the auxdisplay-7seg/pr branch from d26c697 to 3c94e1e Compare November 12, 2024 10:34

decsny requested changes Nov 12, 2024

View reviewed changes

thedjnK previously approved these changes Nov 28, 2024

View reviewed changes

xingrz dismissed thedjnK’s stale review via d5e0de5 November 28, 2024 16:51

xingrz force-pushed the auxdisplay-7seg/pr branch from 3c94e1e to d5e0de5 Compare November 28, 2024 16:51

thedjnK previously approved these changes Nov 28, 2024

View reviewed changes

kartben previously approved these changes Nov 28, 2024

View reviewed changes

pdgendt previously requested changes Nov 28, 2024

View reviewed changes

drivers/auxdisplay/auxdisplay_gpio_7seg.c Outdated Show resolved Hide resolved

xingrz dismissed stale reviews from kartben and thedjnK via 286a0d2 November 29, 2024 02:15

xingrz force-pushed the auxdisplay-7seg/pr branch from d5e0de5 to 286a0d2 Compare November 29, 2024 02:15

kartben requested changes Nov 29, 2024

View reviewed changes

xingrz force-pushed the auxdisplay-7seg/pr branch 2 times, most recently from 14a5702 to 6992fec Compare November 29, 2024 06:10

xingrz added 2 commits November 29, 2024 21:55

drivers: auxdisplay: Add driver for common 7-segment display

3abb245

This commit introduces a new driver for a common GPIO-driven 7-segment display. supporting both common anode and common cathode configurations. Signed-off-by: Chen Xingyu <[email protected]>

xingrz force-pushed the auxdisplay-7seg/pr branch from 6992fec to 92a721d Compare November 29, 2024 13:56

thedjnK requested review from decsny, kartben and cfriedt December 1, 2024 09:28

thedjnK approved these changes Dec 1, 2024

View reviewed changes

kartben approved these changes Dec 1, 2024

View reviewed changes

cfriedt approved these changes Dec 1, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

drivers: auxdisplay: Add driver for common 7-segment display #68501

drivers: auxdisplay: Add driver for common 7-segment display #68501

xingrz commented Feb 3, 2024 •

edited

Loading

thedjnK Feb 7, 2024

xingrz Feb 8, 2024

thedjnK Feb 7, 2024

thedjnK Feb 7, 2024

xingrz Feb 8, 2024

xingrz commented Mar 19, 2024

thedjnK commented Apr 9, 2024

github-actions bot commented Jun 9, 2024

cfriedt commented Aug 12, 2024

xingrz commented Aug 13, 2024

thedjnK commented Aug 13, 2024

cfriedt commented Aug 13, 2024

thedjnK left a comment

thedjnK Sep 11, 2024

thedjnK Sep 11, 2024

github-actions bot commented Nov 11, 2024

cfriedt commented Nov 12, 2024

xingrz commented Nov 12, 2024

decsny Nov 12, 2024

xingrz Nov 28, 2024

thedjnK commented Nov 28, 2024

xingrz commented Nov 28, 2024

kartben left a comment

xingrz commented Nov 29, 2024

xingrz commented Nov 29, 2024

thedjnK commented Dec 1, 2024

drivers: auxdisplay: Add driver for common 7-segment display #68501

Are you sure you want to change the base?

drivers: auxdisplay: Add driver for common 7-segment display #68501

Conversation

xingrz commented Feb 3, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

xingrz commented Mar 19, 2024

thedjnK commented Apr 9, 2024

github-actions bot commented Jun 9, 2024

cfriedt commented Aug 12, 2024

xingrz commented Aug 13, 2024

thedjnK commented Aug 13, 2024

cfriedt commented Aug 13, 2024

thedjnK left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Nov 11, 2024

cfriedt commented Nov 12, 2024

xingrz commented Nov 12, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

thedjnK commented Nov 28, 2024

xingrz commented Nov 28, 2024

kartben left a comment

Choose a reason for hiding this comment

xingrz commented Nov 29, 2024

xingrz commented Nov 29, 2024

thedjnK commented Dec 1, 2024

xingrz commented Feb 3, 2024 •

edited

Loading