mgmt: mcumgr: transport: smp: Fix smp_init runlevel. #82142
+6
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bas-archembedded
force-pushed
the
fix_smp_init_run_level
branch
2 times, most recently
from
b2dbac9
to
24b353f
Compare
nordicjm
requested changes
Nov 28, 2024
Make initialization priority of smp_init() higher when CONFIG_SMP_CLIENT is enabled. The smp_init() routine was called after smp_init_uart(), causing the list to be emptied again after registration of the uart client transport. Signed-off-by: Bas van Loon <[email protected]>
bas-archembedded
force-pushed
the
fix_smp_init_run_level
branch
from
24b353f
to
3fc79e0
Compare
nordicjm
reviewed
Dec 2, 2024
There was a problem hiding this comment.
As an alternative without having to mess with init levels which seems messy, have you tried having the slist init'd statically instead using https://docs.zephyrproject.org/latest/doxygen/html/group__single-linked-list__apis.html#ga7f4710125f45643b7acdaa58dbfff225 ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move priority to POST_KERNEL to make sure smp_init() is called before smp_init_uart as it initializes the transport list in case CONFIG_SMP_CLIENT is enabled.
The smp_init() routine was called after smp_init_uart(), causing the list to be emptied again after registration of the uart client transport.