-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix tests scenarios failing with undefined reference to z_impl_sys_rand_get
#82346
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure about this change.
The documentation for the option states:
This option is intended to be selected only by application-level
configurations (e.g. in tests and samples) to indicate that the
application is allowed to run with a random number generator that is not
truly random. Board-level configurations must not select this option
unless the sole purpose of the board is testing (e.g. QEMU emulation
boards).
Not sure if we can consider these cases here tests.
Furthermore, the option is hardened, which will give a build warning. That doesn't like something we really want to have in samples.
An alternative to this PR is to remove the boards that do not support a random generator for applications that require a random generator.
Enable entropy generator as needed by these samples. Fixes zephyrproject-rtos#82344 Signed-off-by: Manuel Argüelles <[email protected]>
Enable entropy generator as needed by these tests. Fixes zephyrproject-rtos#82344 Signed-off-by: Manuel Argüelles <[email protected]>
4d95693
to
078b2aa
Compare
my bad, it seems that is possible to enable |
Doing a search for I'm not sure which way is "correct" |
I based on https://github.com/zephyrproject-rtos/zephyr/blob/main/samples/bluetooth/peripheral_ht/boards/frdm_rw612.conf#L2. I'm not familiar enough with the tests to enable it at prj.conf, so I'll let others with better knowledge than me on this to comment. |
I'd assume it's the enabling of Bluetooth that brings this dependency. It might make more sense to do this as a select statement in the HCI driver that this board uses, similar to what was done for ESP32 here: #82198 |
It's using the I see from https://github.com/zephyrproject-rtos/zephyr/pull/79931/files three other different approaches to this same problem:
If the dependency comes from the |
I need to take a look of it's some subset of Bluetooth functionality (or subset boards with Bluetooth) that need this, or if it's always needed. If it's the latter, maybe we should just add the select to |
Right now this seems to be fixing this on a per-app basis, which would then leave all other Bluetooth apps broken with this board. So out of the various alternatives being discussed that's probably the worst option. |
Could you try if the same issue gets fixed by #82363? If so, then we should probably move to that instead of selecting |
@jhedberg agree, it fixes the issue indeed, thanks! Btw you may want to also cleanup all the tests/samples overlays that are selecting |
moved to #82363 |
Some tests are failing with undefined reference to
z_impl_sys_rand_get
for boardshexiwear/mk64f12
andfrdm_k64f/mk64f12
.It looks like these boards lack of RNG driver and and the test scenarios are not enabling any test RNG, so enable it.Not sure about side effects, so I'm open to better suggestions -I'm just trying to unblock unrelated CI failures in another pr.
Fixes #82344