acinclude.m4: check if -latomic is needed. #3083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On some cases, -latomic is needed for likning, and since the current acinclude.m4 checks only compilation we can sometimes miss the need for -latomic and the linking process will fail. Therefore, the AC_CHECK_IFELSE was replaced with AC_LINK_IFELSE. If the first try fails, we try to link again with -latomic and add LIBS="-latmoic" in case we succeeded. Signed-off-by: Asaf Kahlon <[email protected]>
woodsts
pushed a commit
to woodsts/buildroot
that referenced
this pull request
May 8, 2018
Fixes: http://autobuild.buildroot.net/results/b149aa2ee00e4d6a53c884cf99ecb2dd8af58b65/ http://autobuild.buildroot.net/results/e4b3616ac2695d3b6898185a70da6509b1faa2b8/ Patch the package to check if -latomic is needed to be added, depending on the result of AC_LINK_IFELSE. The patch was sent to upstream, see: zeromq/libzmq#3083 Signed-off-by: Asaf Kahlon <[email protected]> Signed-off-by: Thomas Petazzoni <[email protected]>
ananos
pushed a commit
to ananos/buildroot
that referenced
this pull request
Jun 15, 2018
Fixes: http://autobuild.buildroot.net/results/b149aa2ee00e4d6a53c884cf99ecb2dd8af58b65/ http://autobuild.buildroot.net/results/e4b3616ac2695d3b6898185a70da6509b1faa2b8/ Patch the package to check if -latomic is needed to be added, depending on the result of AC_LINK_IFELSE. The patch was sent to upstream, see: zeromq/libzmq#3083 Signed-off-by: Asaf Kahlon <[email protected]> Signed-off-by: Thomas Petazzoni <[email protected]>
|
@asafkahlon could you please send a new pull request or an email with a relicense statement? As explained in https://github.com/zeromq/libzmq/blob/master/.github/CONTRIBUTING.md and https://github.com/zeromq/libzmq/tree/master/RELICENSE we are trying to relicense libzmq under MPL-2. Thank you! |
|
@asafkahlon another ping. Please consider helping us with the relicense. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On some cases, -latomic is needed for likning, and since the current
acinclude.m4 checks only compilation we can sometimes miss the need for -latomic
and the linking process will fail.
Therefore, the AC_CHECK_IFELSE was replaced with AC_LINK_IFELSE. If the first
try fails, we try to link again with -latomic and add LIBS="-latmoic" in case we
succeeded.
Signed-off-by: Asaf Kahlon [email protected]