-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor protocol literals into constants #3847
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bluca
reviewed
Mar 14, 2020
Solution: replace into named constants
Conditinoal compile for OPENPGM and NORM is mixed. Also found few codes which needs conditional compile but not applied. Solution: Apply conditional compile preprocessors
5a933a0
to
0946875
Compare
Added new commit to resolve previous ifdef tricks, rebased from master branch. |
there's a formatting problem |
0946875
to
b06a6d9
Compare
Fixed formatting issue, ammended in last commit |
still errors:
|
Some ifdefs in condition checking may cause problem in some compiler or static analyzers. When PGM and NORM both are disabled, some condition will be derived as false || false. Solution: Splitted condition checking for every ifdef conditions
b06a6d9
to
38fd1fd
Compare
I thought only tab->space problems. I just realized using clang-format. clang-format patches applied. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Protcol string for PGM, EPGM and NORM is still represented in literal strings.
While changing literals into constants, I also applied conditional compile for them.
Some code blocks didn't covered with conditional compile, and the others is using both PGM and NORM.
I tried to change those code blocks as simple as possible, but some code blocks seems messy.
I want someone review and comment especially for following code blocks. (I've marked WiP just for review)
Code block1
Code block2
Code block3