Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adhesion à l'association via helloasso #5468

Merged
merged 7 commits into from
Oct 9, 2019

Conversation

firm1
Copy link
Contributor

@firm1 firm1 commented Oct 8, 2019

Cette PR permet d'utiliser le nouveau modèle d'inscription à l'association qui est Helloasso. On remplace l'ancienne mécanique par une redirection vers la page Helloasso d'adhesion.

Ce lien est biensur paramétrable dans le settings pour facilité la mise à jour chaque année de ce dernier.

Contrôle qualité

  • démarrer le site make run-back
  • Allez sur la page d'accueil et constatez que dans le footer, le bouton "Adhérer à l'association" renvoit maintenant vers helloasso.

@coveralls
Copy link

Coverage Status

Coverage remained the same at ?% when pulling e939212 on firm1:move_to_helloasso into ded5ff9 on zestedesavoir:dev.

@coveralls
Copy link

coveralls commented Oct 8, 2019

Coverage Status

Coverage decreased (-3.9%) to 68.739% when pulling 0297d14 on firm1:move_to_helloasso into ded5ff9 on zestedesavoir:dev.

Copy link
Member

@Situphen Situphen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merci pour ta PR ! Deux petites choses à modifier et c'est bon. :)

@@ -77,7 +77,8 @@
'fee': zds_config.get('association_fee', '20 €'),
'email': '[email protected]',
'email_ca': '[email protected]',
'forum_ca_pk': 25
'forum_ca_pk': 25,
'suscribe_link': 'https://www.helloasso.com/associations/zeste-de-savoir/adhesions/zeste-de-savoir-cotisations-2018'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correction du mot "subscribe" et utilisation de zds_config pour pouvoir changer la configuration sans devoir attendre une nouvelle version de ZDS

Suggested change
'suscribe_link': 'https://www.helloasso.com/associations/zeste-de-savoir/adhesions/zeste-de-savoir-cotisations-2018'
'subscribe_link': zds_config.get('association_subscribe_link', 'https://www.helloasso.com/associations/zeste-de-savoir/adhesions/zeste-de-savoir-cotisations-2018')

{% if user.is_authenticated %}
<li><a href="{% url "pages-assoc-subscribe" %}">{% trans "Adhérer" %}</a></li>
{% endif %}
<li><a href="{{ app.site.association.suscribe_link }}">{% trans "Adhérer à l'association" %}</a></li>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<li><a href="{{ app.site.association.suscribe_link }}">{% trans "Adhérer à l'association" %}</a></li>
<li><a href="{{ app.site.association.subscribe_link }}">{% trans "Adhérer à l'association" %}</a></li>

Copy link
Member

@Situphen Situphen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA : OK !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants