passe à django 3 #6065
Closed
passe à django 3 #6065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Il y a quelques points à investiguer avant de valider le passage à Django 3.1 #6008 |
Le plus gros effet que ça a sur nous c'est que du coup notre formulaire qui liste des catégories et qui habituellement recevait des string/int reçoit désormais cet objet. Il faut donc déréférencer la value pour avoir l'objet désiré
artragis
force-pushed
the
django_31_for_async
branch
from
bb1c238 to
ec8abc6
Compare
Situphen
requested changes
Apr 25, 2021
There was a problem hiding this comment.
Je pense qu'il serait bien de fusionner cette PR après la v30.1 car ce n'est pas urgent et comme ça on aura plusieurs mois pour détecter de potentielles régressions. D'ailleurs amha l'idéal serait d'attendre que drf-extensions soit 3.2-compatible avant de fusionner pour être sur une LTS. (Je met "Request changes" pour bloquer la fusion.)
|
Remplacée par #6217 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contrôle qualité
Aller sur le site et valider que tout est ok. notamment la navigation entre les liens internes.