Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mise à jour triviale des dépendances Node.js #6341

Merged
merged 2 commits into from
Jun 26, 2022

Conversation

Situphen
Copy link
Member

@Situphen Situphen commented Jun 25, 2022

Mise à jour des dépendances Node.js, sauf gulp-imagemin car c'est maintenant un ESM (EcmaScript Module) donc il faut convertir Gulpfile.js en ESM lui aussi pour que ça fonctionne (ce que je n'ai pas réussi).

Concernant ESLint, eslint-plugin-node a été remplacé par eslint-plugin-n et j'ai désactivé la nouvelle règle object-shorthand pour l'instant car elle me parait plus superflue qu'autre chose.

QA :

  • source zdsenv/bin/activate && make update && make zmd-start && make run-back
  • Vérifier que le site web fonctionne correctement dans sa globalité

@Situphen Situphen added the C-Front Concerne l'interface du site label Jun 25, 2022
@coveralls
Copy link

coveralls commented Jun 25, 2022

Coverage Status

Coverage remained the same at 87.99% when pulling 97a87bf on Situphen:node-deps into d166c8c on zestedesavoir:dev.

Copy link
Member

@philippemilink philippemilink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA OK ✔️

@philippemilink philippemilink enabled auto-merge (squash) June 26, 2022 15:30
@philippemilink philippemilink merged commit 1b808cf into zestedesavoir:dev Jun 26, 2022
@Situphen Situphen deleted the node-deps branch June 26, 2022 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-Front Concerne l'interface du site
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants