Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remplacement de toml par tomli #6418

Merged
merged 1 commit into from
Dec 5, 2022
Merged

Remplacement de toml par tomli #6418

merged 1 commit into from
Dec 5, 2022

Conversation

Situphen
Copy link
Member

@Situphen Situphen commented Nov 7, 2022 •
edited
Loading

Remplacement de toml par tomli

Lié au ticket #6417

QA : Mettre la PR sur la bêta et vérifier que le site fonctionne correctement

@Situphen Situphen added the C-Back Concerne le back-end Django label Nov 7, 2022
@coveralls
Copy link

coveralls commented Nov 7, 2022 •
edited
Loading

Coverage Status

Coverage remained the same at 88.299% when pulling 1df1b9a on Situphen:toml into a333b4c on zestedesavoir:dev.

philippemilink
philippemilink requested changes Dec 5, 2022
View reviewed changes
Copy link
Member

@philippemilink philippemilink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Certaines parties des changements dans le code m'ont un peu perturbées, donc je propose de rajouter des commentaires pour clarifier tout ça :)

zds/settings/abstract_base/config.py Show resolved Hide resolved
requirements.txt Outdated Show resolved Hide resolved
@Situphen
Copy link
Member Author

Situphen commented Dec 5, 2022 •
edited
Loading

Bon, je n'ai pas pu m'empêcher de réécrire les commentaires à ma façon, mais ils sont là !

philippemilink
philippemilink approved these changes Dec 5, 2022
View reviewed changes
Copy link
Member

@philippemilink philippemilink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rapport de QA

Déployé sur la bêta et tout semble bien fonctionner.

QA OK ✔️

@philippemilink philippemilink merged commit e2633f1 into zestedesavoir:dev Dec 5, 2022
@Situphen Situphen deleted the toml branch December 5, 2022 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philippemilink philippemilink philippemilink approved these changes

Assignees
No one assigned
Labels
C-Back Concerne le back-end Django
Projects
Suivi des PR
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Situphen @coveralls @philippemilink