Open link in new tab doesn't seem to work in Zetta Browser

[landlessness]

If I COMMAND-Click a link in the Zetta browser it doesn't open the link in a new tab as I expect it to do. Instead it treats the Click like a regular, old click.

[13protons]

At first glance, this looks like it's being caused by javascript handling the click, rather than the browser handling it natively. I'll see if I can change the way that click is handled to get the expected behavior.

[kevinswiber]

@alanguir There are no href attributes assigned to the links. Angular handles the click event. We could figure out the href values, but new tabs will result in full API reloads. Without saving to some kind of browser storage, that's the best we can do. Still... sounds do-able. I made sure each page has a link that can be shared. The lack of share-able links is a huge downside to single page apps, and I didn't want us to suffer the same fate.

[13protons]

@kevinswiber re:making sure each page has a link that can be shared, do you mean copying the url from the browser address bar on any page in the zetta browser should be sharable?

[kevinswiber]

Yes.

Sent from my iPhone

On Oct 13, 2014, at 10:42 PM, Alan Languirand [email protected]
wrote:

@kevinswiber https://github.com/kevinswiber re:making sure each page has
a link that can be shared, do you mean copying the url from the browser
address bar on any page in the zetta browser should be sharable?

—
Reply to this email directly or view it on GitHub
#11 (comment).

[13protons]

@kevinswiber If we make this an href will we still have to reload the full API each time?

https://github.com/zettajs/zetta-browser/blob/master/src/partials/overview.html#L33

It might actually be easier to chase down the keybindings:

http://stackoverflow.com/questions/3902635/how-does-one-capture-a-macs-command-key-via-javascript

[kevinswiber]

Yup.

On Wed, Oct 29, 2014 at 11:18 AM, Alan Languirand [email protected]
wrote:

@kevinswiber https://github.com/kevinswiber If we make this an href
will we still have to reload the full API each time?

https://github.com/zettajs/zetta-browser/blob/master/src/partials/overview.html#L33

—
Reply to this email directly or view it on GitHub
#11 (comment)
.

Kevin Swiber
Projects: https://github.com/kevinswiber
Twitter: @kevinswiber