Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Device log messages not present on device's "logs" stream #287

Open
kyork-cl opened this issue Jan 28, 2016 · 3 comments
Open

Device log messages not present on device's "logs" stream #287

kyork-cl opened this issue Jan 28, 2016 · 3 comments

Comments

@kyork-cl
Copy link
Contributor

Whenever a device.log() call is made, the output appears in the console and on the servers "logs" topic, but not on the device's "logs" topic.

The message object received from the server's "logs" topic also doesn't have an indication of the source of the log, other than the device's name which could be duplicated or not exist.

    {"topic":"logs","timestamp":1454007921652,"msg":"1454007921652","level":"info","event":"my-device-log"}

Could the message that comes from the server "logs" include the ID of the device? Or possible modify the topic to follow the protocol of the WebSocket event stream?

Additionally, could device log messages be available on the device's "logs" stream?

@AdamMagaluk
Copy link
Collaborator

Thanks @kyork-cl.

I agree, when using .log() from the device i'd expect it to show up on the devices log stream.

Also I think we should modify the current log format in the server's log to at least show the devices id.

@kevinswiber @mdobson Any thoughts on the proposed changes?

@mdobson
Copy link
Contributor

mdobson commented Jan 29, 2016

Nope. What would the websocket format look like? Something like:

{
"topic":"",
"timestamp":"",
"data": "LOG MESSAGE"
}

--
Matthew Dobson | apigee https://apigee.com/ | m: +1.734.634.5472 |
twitter @mdobs http://twitter.com/mdobs @apigee
https://twitter.com/apigee | Apigee Community
http://community.apigee.com/
for answers, ideas and support!

On Fri, Jan 29, 2016 at 10:39 AM, Adam Magaluk [email protected]
wrote:

Thanks @kyork-cl https://github.com/kyork-cl.

I agree, when using .log() from the device i'd expect it to show up on
the devices log stream.

Also I think we should modify the current log format in the server's log
to at least show the devices id.

@kevinswiber https://github.com/kevinswiber @mdobson
https://github.com/mdobson Any thoughts on the proposed changes?


Reply to this email directly or view it on GitHub
#287 (comment).

@AdamMagaluk
Copy link
Collaborator

Also to note the current device log streams do not show up in the the multiplexed websocket when subscribed to **

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants