Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Peer socket refactor #77

Merged
merged 30 commits into from
Oct 13, 2014
Merged

Peer socket refactor #77

merged 30 commits into from
Oct 13, 2014

Conversation

AdamMagaluk
Copy link
Collaborator

  1. Removed peer setup logic out of http_server and all into peer_socket.
  2. Cleaned up http_servers use of .router/.peers/.agents to only use .peers[<peer_name>]
  3. Removed server's id, urls now use server's name. Note: there is still a .id on zetta which is set to the name for now.
    3.a peer_registry uses id which is set to the peers name when in the perspective of a cloud server.
    3.b peer_registry uses a v4 uuid for a id key for peers in the perspective of a local server.
  4. peer_socket now has property called .name which is the server name, event_broker updated to use this.

…tta.js only sends peer

when _peer/connect and _peer/disconnect
@kevinswiber
Copy link
Member

There's a lot here. Still going through it. Related to the name change, we should alter the server API response so it doesn't include the id in the properties. We also need to make sure server names are URI-encoded for the representations.

@kevinswiber
Copy link
Member

(For URLs in representations, that is.)

@kevinswiber
Copy link
Member

Pending the above changes, this looks good to merge!

kevinswiber added a commit that referenced this pull request Oct 13, 2014
@kevinswiber kevinswiber merged commit 2d89040 into master Oct 13, 2014
@kevinswiber kevinswiber deleted the peer-socket-refactor branch October 13, 2014 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants