-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Peer socket refactor #77
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eout is now a var
…netSocket.on('end') for connection close
…et name. Has it from url.
…tta.js only sends peer when _peer/connect and _peer/disconnect
…in subscriptions in peer_socket
There's a lot here. Still going through it. Related to the name change, we should alter the server API response so it doesn't include the id in the properties. We also need to make sure server names are URI-encoded for the representations. |
(For URLs in representations, that is.) |
Pending the above changes, this looks good to merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.id
on zetta which is set to the name for now.3.a peer_registry uses id which is set to the peers name when in the perspective of a cloud server.
3.b peer_registry uses a v4 uuid for a id key for peers in the perspective of a local server.