ui: query peer review frontend #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jczhong84
reviewed
Dec 12, 2024
Comment on lines
95
to
97
| toast.success( | ||
| 'Review request sent! Your reviewers have been notified, and if approved, your query will be executed.' | ||
| ); |
There was a problem hiding this comment.
after sending the request, where can the user to check all the requested executions and their status?
There was a problem hiding this comment.
Good point, I will need to create 2nd tab in Request Review Modal above to monitor existing all reviews.
I think we can also add a link in the QueryExecutionBar to review. Will handle these in later PR, and also copy paste review link ability
Comment on lines
129
to
130
| message="Tip: Before submitting your sensitive query for review, run it once to validate its syntax and feasibility. This helps identify errors early and reduces unnecessary review cycles." | ||
| /> |
There was a problem hiding this comment.
wanna put the tip into the public config as well?
jczhong84
reviewed
Dec 16, 2024
querybook/webapp/components/QueryPeerReviewModal/QueryPeerReviewModal.tsx
Outdated
Show resolved
Hide resolved
zhangvi7
force-pushed
the
peer-review/frontend
branch
from
d122269 to
76f8903
Compare
jczhong84
approved these changes
Dec 17, 2024
feat: peer review backend endpoints
db: Add query review tables and update QueryExecutionStatus enum
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Changes
Test Plan
Enabling query engine feature toggle
Requesting a review on an execution
review.demo.mov
Updated Request Review Modal