fix: disable lazy import for line chart and box plot (#82)

* fix: disable lazy import * fix: lint
zhaoyongjie · Nov 17, 2021 · 465495c · 465495c
1 parent e08253c
commit 465495c
Show file tree

Hide file tree

Showing 5 changed files with 12 additions and 8 deletions.
diff --git a/.../plugins/superset-ui-plugins/packages/superset-ui-preset-chart-xy/src/BoxPlot/BoxPlot.tsx b/.../plugins/superset-ui-plugins/packages/superset-ui-preset-chart-xy/src/BoxPlot/BoxPlot.tsx
@@ -25,7 +25,7 @@ import { createSelector } from 'reselect';
 import createTooltip from './createTooltip';
 import XYChartLayout from '../utils/XYChartLayout';
 import WithLegend from '../components/WithLegend';
-import ChartLegend from '../components/ChartLegend';
+import ChartLegend from '../components/legend/ChartLegend';
 import Encoder, { ChannelTypes, Encoding, Outputs } from './Encoder';
 import { Dataset, PlainObject } from '../encodeable/types/Data';
 
@@ -52,6 +52,9 @@ type Props = {
 export default class BoxPlot extends React.PureComponent<Props> {
   static defaultProps = defaultProps;
 
+  encoder: Encoder;
+  private createEncoder: () => void;
+
   constructor(props: Props) {
     super(props);
 
@@ -68,9 +71,6 @@ export default class BoxPlot extends React.PureComponent<Props> {
     this.renderChart = this.renderChart.bind(this);
   }
 
-  encoder: Encoder;
-  private createEncoder: () => void;
-
   renderChart(dim: Dimension) {
     const { width, height } = dim;
     const { data, encoding, margin, theme } = this.props;

diff --git a/...-ui/plugins/superset-ui-plugins/packages/superset-ui-preset-chart-xy/src/BoxPlot/index.ts b/...-ui/plugins/superset-ui-plugins/packages/superset-ui-preset-chart-xy/src/BoxPlot/index.ts
@@ -19,11 +19,12 @@
 import { ChartPlugin } from '@superset-ui/chart';
 import createMetadata from './createMetadata';
 import transformProps from './transformProps';
+import Chart from './BoxPlot';
 
 export default class BoxPlotChartPlugin extends ChartPlugin {
   constructor() {
     super({
-      loadChart: () => import('./BoxPlot'),
+      Chart,
       metadata: createMetadata(),
       transformProps,
     });

diff --git a/...gins/superset-ui-plugins/packages/superset-ui-preset-chart-xy/src/BoxPlot/legacy/index.ts b/...gins/superset-ui-plugins/packages/superset-ui-preset-chart-xy/src/BoxPlot/legacy/index.ts
@@ -19,11 +19,12 @@
 import { ChartPlugin } from '@superset-ui/chart';
 import createMetadata from '../createMetadata';
 import transformProps from './transformProps';
+import Chart from '../BoxPlot';
 
 export default class BoxPlotChartPlugin extends ChartPlugin {
   constructor() {
     super({
-      loadChart: () => import('../BoxPlot'),
+      Chart,
       metadata: createMetadata(true),
       transformProps,
     });

diff --git a/...set-ui/plugins/superset-ui-plugins/packages/superset-ui-preset-chart-xy/src/Line/index.ts b/...set-ui/plugins/superset-ui-plugins/packages/superset-ui-preset-chart-xy/src/Line/index.ts
@@ -3,12 +3,13 @@ import transformProps from './transformProps';
 import createMetadata from './createMetadata';
 import buildQuery from './buildQuery';
 import ChartFormData from './ChartFormData';
+import Chart from './Line';
 
 export default class LineChartPlugin extends ChartPlugin<ChartFormData> {
   constructor() {
     super({
       buildQuery,
-      loadChart: () => import('./Line'),
+      Chart,
       metadata: createMetadata(),
       transformProps,
     });

diff --git a/...plugins/superset-ui-plugins/packages/superset-ui-preset-chart-xy/src/Line/legacy/index.ts b/...plugins/superset-ui-plugins/packages/superset-ui-preset-chart-xy/src/Line/legacy/index.ts
@@ -1,11 +1,12 @@
 import { ChartPlugin } from '@superset-ui/chart';
 import transformProps from './transformProps';
 import createMetadata from '../createMetadata';
+import Chart from '../Line';
 
 export default class LineChartPlugin extends ChartPlugin {
   constructor() {
     super({
-      loadChart: () => import('../Line'),
+      Chart,
       metadata: createMetadata(true),
       transformProps,
     });