chore(plugin-chart-echarts): bump echarts to 5.1.2 (apache#1159)

zhaoyongjie · Nov 25, 2021 · 4f35689 · 4f35689
1 parent aa93f17
commit 4f35689
Show file tree

Hide file tree

Showing 4 changed files with 2 additions and 8 deletions.
diff --git a/...rset-frontend/temporary_superset_ui/superset-ui/plugins/plugin-chart-echarts/package.json b/...rset-frontend/temporary_superset_ui/superset-ui/plugins/plugin-chart-echarts/package.json
@@ -30,7 +30,7 @@
     "@superset-ui/core": "0.17.56",
     "@types/mathjs": "^6.0.7",
     "d3-array": "^1.2.0",
-    "echarts": "^5.1.1",
+    "echarts": "^5.1.2",
     "lodash": "^4.17.15",
     "mathjs": "^8.0.1"
   },

diff --git a/.../temporary_superset_ui/superset-ui/plugins/plugin-chart-echarts/src/Tree/controlPanel.tsx b/.../temporary_superset_ui/superset-ui/plugins/plugin-chart-echarts/src/Tree/controlPanel.tsx
@@ -70,10 +70,10 @@ const controlPanel: ControlPanelConfig = {
         ],
         [
           {
-            // TODO: Set renderTrigger to true without getting intermittent errors in echart
             name: 'root_node_id',
             config: {
               ...optionalEntity,
+              renderTrigger: true,
               type: 'TextControl',
               label: t('Root node id'),
               description: t('Id of root node of the tree.'),

diff --git a/...orary_superset_ui/superset-ui/plugins/plugin-chart-echarts/src/Treemap/EchartsTreemap.tsx b/...orary_superset_ui/superset-ui/plugins/plugin-chart-echarts/src/Treemap/EchartsTreemap.tsx
@@ -93,7 +93,6 @@ export default function EchartsTreemap({
       echartOptions={echartOptions}
       eventHandlers={eventHandlers}
       selectedValues={selectedValues}
-      forceClear
     />
   );
 }
diff --git a/.../temporary_superset_ui/superset-ui/plugins/plugin-chart-echarts/src/components/Echart.tsx b/.../temporary_superset_ui/superset-ui/plugins/plugin-chart-echarts/src/components/Echart.tsx
@@ -32,7 +32,6 @@ export default function Echart({
   echartOptions,
   eventHandlers,
   selectedValues = {},
-  forceClear = false,
 }: EchartsProps) {
   const divRef = useRef<HTMLDivElement>(null);
   const chartRef = useRef<ECharts>();
@@ -50,10 +49,6 @@ export default function Echart({
       chartRef.current?.on(name, handler);
     });
 
-    if (forceClear) {
-      chartRef.current.clear();
-    }
-
     chartRef.current.setOption(echartOptions, true);
 
     chartRef.current.dispatchAction({