fix the remove unused installations cleanup

[Techatrix]

The VS Code documentation says that the deactivate function can be async but it doesn't seem to work.

The sorting was also wrong.

[Vexu]

The VS Code documentation says that the deactivate function can be async but it doesn't seem to work.

Is it not a problem for deactivating ZLS too? Can you describe the issue a bit more? Was the function not being run?

[Techatrix]

Can you describe the issue a bit more? Was the function not being run?

Changing the deactivate function to the following will show the problem:

function delay(timeout: number): Promise<void> {
    return new Promise((resolve) => {
        setTimeout(() => {
            resolve();
        }, timeout);
    });
}

export async function deactivate() {
    appendFileSync("/home/techatrix/repos/vscode-zig/output.log", "Start\n");
    await delay(2000);
    appendFileSync("/home/techatrix/repos/vscode-zig/output.log", "End\n");
}

After restarting the extension, the output.log file will only contain Start which indicates that vscode did not await the returned promise. Reducing the delay to a very low value like 10 works as expected. I tried different values and I got inconsistent result around 300ms. The API docs do state that it is possible to return a promise and microsoft/vscode#47881 says that the extension has 5 seconds to shut down.

Also, the deactivate is only called when restarting the extension but not when closing vscode making it useless to cleanup unused Zig/ZLS installations.

Is it not a problem for deactivating ZLS too?

Good point. I didn't check this before but the time limit is enough to shutdown ZLS. The stopClient finishes successfully but any calls to removeUnusedInstallations don't. It struggled to get past the vscode.workspace.fs.readDirectory call.

---

After looking back at this PR, I think it better to call removeUnusedInstallations after installing a new Zig or ZLS version instead of calling it in the activate function.

[Vexu]

Thanks for the detailed response!