macho: handle -headerpad and -headerpad_max_install_names
#11929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubkon
changed the title
-headerpad_size and -headerpad_max_install_names-headerpad and -headerpad_max_install_names
|
I like the changes to the linker test structure 👍 |
Includes both traditiona and incremental codepaths with one caveat that in incremental case, the requested size cannot be smaller than the default padding size due to prealloc required due to incremental nature of linking. Also parse `-headerpad_max_install_names`, however, not actionable just yet - missing implementation.
kubkon
force-pushed
the
headerpad_max_install_names
branch
from
5011855 to
589bf67
Compare
motiejus
reviewed
Jun 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tweaks link-tests and specifically, refactors and pulls
MatchActionandComputeEqActioninto a singleActionstruct with two parsers attached to itfn match(...)andfn computeCmp(...). The former is as it was, however, the latter now generalises the concept ofComputeEqActionby deferring parsing until we actually execute the test (fn make(...)), and permitting comparing against either an extracted variable or a literal (currently onlyu64) and allowing for any comparison operator of typestd.math.CompareOperator.cc @Luukdegram due to the above.