-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rework async function semantics #3033
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this prevents a segfault in stack trace printing to activate the segfault handler.
* add implicit cast from `*@frame(func)` to `anyframe->T` or `anyframe`. * add implicit cast from `anyframe->T` to `anyframe`. * `resume` works on `anyframe->T` and `anyframe` types.
fixes async function tests in optimized builds
This was referenced Aug 13, 2019
This was referenced Aug 15, 2019
Follow-up items are in issue #3063. |
This was referenced Aug 16, 2019
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is #2377 as well as #1778.
checklist:
@Frame
of generic function@Frame
of wrong function*@Frame(func)
and anyframe*@Frame(func)
and anyframe->T when the return type matchesconst result = (await a) + (await b);
this causes "Instruction does not dominate all uses" - need spill@typeInfo
for@Frame(func)
await @asyncCall
andawait async
are handled correctly.@asyncCall
with a real@Frame(func)
(the point of this is result pointer)needed bytes is equal to the largest callee's frame
error return trace ptr if applicable.
await
should not be a suspend point when used on a@Frame(func)
andfunc
is blocking.