Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow escaped characters in css selectors #289

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

canvasplay
Copy link

@canvasplay canvasplay commented Dec 26, 2020

Fixes autocomplete for css selectors with escaped characters as described here #288.
Currently only supporting the following escaped characters: \/, \@, \:

Fixes #288

@canvasplay canvasplay changed the title WIP fixes escaped characters in css selectors Allow escaped characters in css selectors Dec 26, 2020
@dziku86
Copy link

dziku86 commented Mar 11, 2021

This doesn't works as expected (or I messed up copying n pasting your code 😴). Now it matches pseudo-classes/elements like .some-class:after and doesn't match classes with escaped characters at all.

@canvasplay
Copy link
Author

canvasplay commented Aug 17, 2021

Hello, sorry for long time inactive.
I fixed the error, now it does not parse unwanted pseudo selectors like :hover, :focus, etc..
Many thanks to @AeonFr helping with the regex.

@brochington
Copy link

@canvasplay Thank you for working on this!

Would it be possible to add an escape for .? I use a CSS class utility lib that is similar to tailwind, and has classes such as hrem-1\.5 for "height of 1.5rem". These classes are not detected by the extension.

@canvasplay
Copy link
Author

Hi @brochington, if you don't mind, let's see first if @dziku86 want to merge this ;)

@canvasplay
Copy link
Author

Any news on accepting this @dziku86?

@canvasplay
Copy link
Author

canvasplay commented Jan 21, 2022

Any news on accepting this @dziku86?

Alright! What the thumbs up really means? Are there any inconvenience on merging this PR? I think this is a good addition to the plugin and several people will benefit from it.

@dziku86
Copy link

dziku86 commented Jan 24, 2022

Any news on accepting this @dziku86?

Alright! What the thumbs up really means? Are there any inconvenience on merging this PR? I think this is a good addition to the plugin and several people will benefit from it.

@canvasplay I don't have write access to merge pull requests 😕.

@canvasplay
Copy link
Author

so @zignd, any chances to merge this? some people are interested on this addition.
Thanks in advance for your time!

vain0x added a commit to vain0x/HTML-CSS-Class-Completion that referenced this pull request Sep 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problems with escaped characters
3 participants