Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement]: support config milvus form env. #178

Closed
xushaoxiao opened this issue Aug 11, 2023 · 4 comments
Closed

[Enhancement]: support config milvus form env. #178

xushaoxiao opened this issue Aug 11, 2023 · 4 comments

Comments

@xushaoxiao
Copy link
Contributor

What would you like to be added?

hello teams,

I recently applied the milvus open source project, and made changes to the source code when deploying the backup. I wanted to submit a pr, but the request was denied. Can invite me to join the contributor.

BR.
Shaoxiao.

Why is this needed?

No response

Anything else?

No response
@wayblink
Copy link
Contributor

@xushaoxiao hi, what error you got? It is a public repo, supposed to allow pr from anywhere

@wayblink
Copy link
Contributor

@xushaoxiao I guess you need to folk this repo and submit PR instead of submit to this repo directly

@xushaoxiao
Copy link
Contributor Author

hi @wayblink , thank you. you are right. i want to submit pr for code review.

@xushaoxiao
Copy link
Contributor Author

@xushaoxiao I guess you need to folk this repo and submit PR instead of submit to this repo directly

I try push my fix branch, but got "ERROR: Permission to zilliztech/milvus-backup.git denied to xushaoxiao.
fatal: Could not read from remote repository."

@xushaoxiao xushaoxiao mentioned this issue Aug 18, 2023
Merged
xushaoxiao pushed a commit to xushaoxiao/milvus-backup that referenced this issue Aug 20, 2023
support loading minio and milvus config from env (zilliztech#178)
a5b3bf4 
Signed-off-by: shaoxiaoxu <[email protected]>
xushaoxiao pushed a commit to xushaoxiao/milvus-backup that referenced this issue Aug 20, 2023
support loading minio and milvus config from env (zilliztech#178)
a42c359 
Signed-off-by: Shaoxiao Xu [email protected]
xushaoxiao pushed a commit to xushaoxiao/milvus-backup that referenced this issue Aug 20, 2023
support loading minio and milvus config from env (zilliztech#178)
80c754e 
Signed-off-by: Shaoxiao Xu <[email protected]>
wayblink pushed a commit that referenced this issue Aug 21, 2023
@xushaoxiao
support loading minio and milvus config from env (#178) (#182)
9afbc4e 
Signed-off-by: Shaoxiao Xu <[email protected]>
Co-authored-by: Shaoxiao Xu <[email protected]>
yelusion2 pushed a commit that referenced this issue Oct 16, 2023
@xushaoxiao @yelusion2
support loading minio and milvus config from env (#178) (#182)
d8e29c5 
Signed-off-by: Shaoxiao Xu <[email protected]>
Co-authored-by: Shaoxiao Xu <[email protected]>
zhuwenxing pushed a commit to zhuwenxing/milvus-backup that referenced this issue Feb 21, 2024
@xushaoxiao @zhuwenxing
support loading minio and milvus config from env (zilliztech#178) (zi…
8bd8729 
…lliztech#182)

Signed-off-by: Shaoxiao Xu <[email protected]>
Co-authored-by: Shaoxiao Xu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wayblink @xushaoxiao