Skip to content

Commit

Permalink
web-api(fix): allow typed token overrides in supported methods
Browse files Browse the repository at this point in the history
Fixes slackapi#1871 with a few other methods:

- admins.apps.clearResolution
- admin.apps.uninstall
- apps.uninstall
  • Loading branch information
zimeg committed Aug 14, 2024
1 parent 3a7d3b5 commit 37d5da4
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions packages/web-api/src/types/request/admin/apps.ts
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ export type AdminAppsApprovedListArguments = Partial<TeamOrEnterpriseID> & Token
& Certified;

// https://api.slack.com/methods/admin.apps.clearResolution
export type AdminAppsClearResolutionArguments = AppID & TeamOrEnterpriseID;
export type AdminAppsClearResolutionArguments = AppID & TeamOrEnterpriseID & TokenOverridable;

// https://api.slack.com/methods/admin.apps.config.lookup
export interface AdminAppsConfigLookupArguments extends TokenOverridable {
Expand Down Expand Up @@ -95,4 +95,4 @@ export type AdminAppsRestrictedListArguments = TeamOrEnterpriseID & Certified &
& CursorPaginationEnabled;

// https://api.slack.com/methods/admin.apps.uninstall
export type AdminAppsUninstallArguments = AppID & TeamOrEnterpriseID;
export type AdminAppsUninstallArguments = AppID & TeamOrEnterpriseID & TokenOverridable;
2 changes: 1 addition & 1 deletion packages/web-api/src/types/request/apps.ts
Original file line number Diff line number Diff line change
Expand Up @@ -34,4 +34,4 @@ export interface AppsManifestValidateArguments extends Partial<AppID>, TokenOver
}

// https://api.slack.com/methods/apps.uninstall
export interface AppsUninstallArguments extends Pick<OAuthCredentials, 'client_id' | 'client_secret'> {}
export interface AppsUninstallArguments extends Pick<OAuthCredentials, 'client_id' | 'client_secret'>, TokenOverridable {}

0 comments on commit 37d5da4

Please sign in to comment.