Feat/support all annotations in scala 3 #1471
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThijsBroersen
force-pushed
the
feat/support-all-annotations-in-scala-3
branch
from
cc205a2 to
dc642a7
Compare
ThijsBroersen
force-pushed
the
feat/support-all-annotations-in-scala-3
branch
from
dc642a7 to
d2cdce5
Compare
ThijsBroersen
changed the base branch from
chore/build/refactor-to-projectmatrix-and-bump-all
to
series/4.x
|
@kyri-petrou @afsalthaj How important is mima atm? I changed Macros to AnnotationMacros and made it private to the magnolia package. I don't think it should be public api. |
ThijsBroersen
commented
Nov 27, 2024
Comment on lines
+340
to
+342
| originalKey.fold(desc)(k => desc.nested(modifyKey(k))) | ||
| // case keys => keys.view.map(k => desc.nested(modifyKey(k))).reduce(_ orElse _) // Looks like the Scala 3 implementation modifies alternative names while the Scala 2 implementations treats them as is. | ||
| case keys => keys.view.map(k => desc.nested(k)).reduce(_ orElse _) |
There was a problem hiding this comment.
please review this carefully, because I think L341 should be enabled and L342 disabled. This changes the existing behaviour only to match the Scala 2 behaviour.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add support for annotations in Scala 3 on all platforms. The added tests are used for testing all platforms and scala versions to ensure unambiguous behaviour.
This PR introduces the
suffixannotation as a replacement forpostfix(to deprecate). Semantics ofpostfixto not properly reflect the feature.