Fix decoding of JsonSchema properties from JSON
#3287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plokhotnyuk
requested review from
jdegoes,
vigoo,
kyri-petrou and
987Nabil
as code owners
plokhotnyuk
force-pushed
the
fix-decoding-of-fallbacks-from-json
branch
from
fc28656 to
3b1de8a
Compare
|
@plokhotnyuk What does this fix? 🤔 |
It is a kind of workaround that reverts a quite legal optimization for decoding of boolean values. But some deeper issue still exits. It is about how |
987Nabil
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.