Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes: #3243 #3296

Closed
Closed

Conversation

deekshatomer
Copy link

/claim #3243

Description:
This PR addresses the issue of nested routes not working as expected.

Changes made:

Fixed the route matching logic for nested routes.
Updated test cases to ensure correctness.
Refactored minor parts of the routing system for better maintainability.

How to test:
Run sbt test (or the appropriate command) to verify the changes.
Manually test various nested routes to confirm the fix.

@CLAassistant
Copy link

CLAassistant commented Feb 11, 2025

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@guizmaii
Copy link
Member

@deekshatomer There's an issue with your PR. It doesn't show only the changes you made. Please fix your PR for us to be able to review

@guizmaii guizmaii marked this pull request as draft February 11, 2025 22:53
@deekshatomer deekshatomer marked this pull request as ready for review February 12, 2025 00:30
@deekshatomer deekshatomer force-pushed the fix-nested-routes-bug-3243 branch from 52541cf to 78f5a8e Compare February 12, 2025 01:11
@deekshatomer deekshatomer force-pushed the fix-nested-routes-bug-3243 branch from 78f5a8e to 668eb91 Compare February 12, 2025 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants