Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplify StreamsBasedServer example #179

Merged
merged 8 commits into from
Oct 21, 2020

Conversation

RoelVanderPaal
Copy link
Contributor

2 of 4 ZStream constructions can be removed

@CLAassistant
Copy link

CLAassistant commented Apr 10, 2020

CLA assistant check
All committers have signed the CLA.

@jczuchnowski jczuchnowski requested a review from iravid May 31, 2020 20:07
jdegoes
jdegoes previously approved these changes Oct 21, 2020
@jdegoes
Copy link
Member

jdegoes commented Oct 21, 2020

@RoelVanderPaal Can you fix conflicts and we can merge? Thanks for your simplifications!

# Conflicts:
#	examples/src/main/scala/StreamsBasedServer.scala
applied latest formatting
Copy link
Contributor

@quelgar quelgar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@quelgar quelgar merged commit c6ce460 into zio:master Oct 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants