Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the example #417

Merged
merged 2 commits into from
Jul 24, 2021
Merged

Update the example #417

merged 2 commits into from
Jul 24, 2021

Conversation

paulpdaniels
Copy link
Collaborator

Closes #415

@paulpdaniels paulpdaniels requested review from mijicd and a team as code owners July 23, 2021 07:17
mijicd
mijicd reviewed Jul 23, 2021
View reviewed changes
Copy link
Member

@mijicd mijicd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work! Just a few nitpicks and it's ready to go!

example/src/main/scala/example/ApiError.scala Outdated Show resolved Hide resolved
example/src/main/scala/example/ApiError.scala Outdated Show resolved Hide resolved
example/src/main/scala/example/Main.scala Outdated Show resolved Hide resolved
example/src/main/scala/example/config/ServerConfig.scala Outdated Show resolved Hide resolved
example/src/main/scala/example/Main.scala Outdated Show resolved Hide resolved
example/src/main/scala/example/Main.scala Outdated Show resolved Hide resolved
@mijicd mijicd merged commit 38a5888 into zio:master Jul 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anovakovic01 anovakovic01 anovakovic01 approved these changes

@mijicd mijicd mijicd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rewrite the example using ZIO libraries
3 participants
@paulpdaniels @mijicd @anovakovic01