unify stream output approaches #473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anatolysergeev
commented
Nov 3, 2021
| @@ -59,6 +59,8 @@ trait Streams { | |||
|
|
|||
| sealed case class StreamEntry[I, K, V](id: I, fields: Map[K, V]) | |||
|
|
|||
| sealed case class Stream[N, I, K, V](name: N, entries: Chunk[StreamEntry[I, K, V]]) | |||
There was a problem hiding this comment.
This class name is arguable. I accept proposals for better))
It has conflict wit zio.stream.Stream, I have to fix imports((
There was a problem hiding this comment.
StreamChunk now
mijicd
reviewed
Nov 3, 2021
| case RespValue.Array(Seq(id @ RespValue.BulkString(_), value)) => | ||
| val eId = ArbitraryOutput[I]().unsafeDecode(id) | ||
| val entry = KeyValueOutput(ArbitraryOutput[K](), ArbitraryOutput[V]()).unsafeDecode(value) | ||
| StreamEntry(id = eId, entry) |
There was a problem hiding this comment.
Suggested change
| StreamEntry(id = eId, entry) | |
| StreamEntry(eId, entry) |
I'd also rename it to entryId.
mijicd
approved these changes
Nov 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.