Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add phone number validations for European countries #251

Open
50 tasks
jdegoes opened this issue May 25, 2022 · 8 comments
Open
50 tasks

Add phone number validations for European countries #251

jdegoes opened this issue May 25, 2022 · 8 comments

Comments

@jdegoes
Copy link
Member

jdegoes commented May 25, 2022

ISSUE

There is no constructor for zio.schema.validation.Validation which can validate a European country phone number.

NOTE: This is 50 tickets in one. Please signup for one or more of the tickets by checking them below.

  • Albania
  • Andorra
  • Armenia
  • Austria
  • Azerbaijan
  • Belarus
  • Belgium
  • Bosnia and Herzegovina
  • Bulgaria
  • Croatia
  • Cyprus
  • Czechia
  • Denmark
  • Estonia
  • Finland
  • France
  • Georgia
  • Germany
  • Greece
  • Hungary
  • Iceland
  • Ireland
  • Italy
  • Kazakhstan
  • Kosovo
  • Latvia
  • Liechtenstein
  • Lithuania
  • Luxembourg
  • Malta
  • Moldova
  • Monaco
  • Montenegro
  • Netherlands
  • North Macedonia
  • Norway
  • Poland
  • Portugal
  • Romania
  • Russia
  • San Marino
  • Serbia
  • Slovakia
  • Slovenia
  • Spain
  • Sweden
  • Switzerland
  • Turkey
  • Ukraine
  • Vatican City (Holy See)

SOLUTION

Using other constructors which already exist in zio.schema.validation.Validation (which include regex validation, string length checking, and numeric range checking), introduce a new constructor that satisfies the requirements of this issue.

object Validation {
  ...
  val phoneNumber<2-Letter CountryCode>: Validation[String] = ???
}

IMPACT

Increasing the number of constructors for Validation will make it far easier to use the validation package to

WHERE TO LOOK

PROBLEMATIC ISSUES

Issue #248 must be completed first, or at least, this issue must be based off of #244.

@BalduinLandolt
Copy link
Contributor

I'll try to get that one started by implementing Switzerland, but once I got the hang of it, I can continue with other countries too.

@marioaae
Copy link
Contributor

I'll try to get into this as well and will start with Germany.

@BalduinLandolt
Copy link
Contributor

@marioaae should we pair up, maybe? If you want to, just ping me on discord (I posted in the zio-schema channel, so you should easily be able to find me)

@subotic
Copy link

subotic commented May 26, 2022

I will try Serbia.

@lmserrano
Copy link

I will try Portugal.

@tewecske
Copy link
Contributor

I will do Hungary.

tewecske added a commit to tewecske/zio-schema that referenced this issue May 27, 2022
tewecske added a commit to tewecske/zio-schema that referenced this issue May 27, 2022
tewecske added a commit to tewecske/zio-schema that referenced this issue May 27, 2022
@jdegoes
Copy link
Member Author

jdegoes commented Oct 24, 2022

This ticket needs to be updated to reflect which validators have already been implemented, and which remain.

@BalduinLandolt
Copy link
Contributor

I can't update the initial task, but I went through the list: all of the validations (and many more) are done, so this issue can be closed, I suppose.
(Only thing I noticed, in the comment the republic of North Macedonia is referred to as the republic of Macedonia, which isn't the official name any more.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants