Override gen annotation for DeriveGen functionality #458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Potentially working needs cleanup Add test to show it ignores a generator of a different type Remove type safety and test Formatting and test name fix Formatting and linting fixes formatting Formatting again
|
@beem812 I feel like the best way to support this would be to re-implement |
|
Sure, I'd be happy to take a look at it and attack it from that path. The lack of type safety from this solution felt weird anyway, hopefully the deriver route eliminates that issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@generator()annotation for specifying a different generator for the DeriveGen functionality to use. #438Allows for overriding the generator at both the field schema and the value schema level