fix: resolve clippy warnings in nightly #252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RisaI
changed the title
|
Thanks for fixing this. It will be merged when the tests pass. |
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
|
Once this PR is merged, we should finally be able to merge #245, which will eliminate nearly all the merge-queue flakiness; that may be a chicken-and-egg problem for the next day or two, but I'll check in on it several times a day to retry if necessary. I've yet to see a good solution for CI workflows that have a pre-existing failure to finish within the 6 hours end-to-end that GitHub allows in merge queues, while still detecting incompatibilities between changes that arrived too close in time for one to run against the other otherwise. |
Closed
This was referenced Nov 19, 2024
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clippy started acting up during nightly checks in CI. This was due to some default error levels for certain lints being changed. This PR resolves these warnings to unblock CI for many open PRs.