Handle website contacts dynamically #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commits change the way contacts params are handled: instead of
declaring them statically, they are declared as an array of tables in
the TOML configuration file, then they are displayed in the two sections
(homepage and footer) of the website through the {{ range }} statement.
This makes handling multiple contacts params easier and avoids the
need of changing manually this two files:
- `layouts/partials/footer.html`;
- `exampleSite/content/homepage/contact.md`;
Signed-off-by: Filippo Fontana <[email protected]>
|
Looks good. I've branched off |
|
The phone link does not seem to work. |
I see, it looks like now you have to include the meta-info directly with the parameter value, |
|
It's broken in gh repo clone zjedi/hugo-scroll
cd hugo-scroll/exampleSite
sed -i 's/showContactIcons\ \=\ false/showContactIcons \= true/g' config.toml
hugo server -t ../..
|
|
I see, the phone link is broken the same way also in the contacts section. @filippofontana Any chance you would have a look at this? |
|
Yes of course, I’ll take a look. |
|
looks fixed in the preview now, thanks for quick action :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
This commits change the way contacts params are handled: instead of declaring them statically, they are declared as an array of tables in the TOML configuration file, then they are displayed in the two sections (homepage and footer) of the website through the {{ range }} statement.
This makes handling multiple contacts params easier and avoids the need of changing manually this two files:
layouts/partials/footer.html;exampleSite/content/homepage/contact.md;Of course this results in a breaking change for the template.
I think this new mechanism could be helpful when you need to add multiple contact options to the template.