Optimize Theme with Assets Bundles and fixes missing lang attribute in HTML #81
Conversation
|
Hi @patrickfav, please excuse my late reply. This looks very good. Currently I don't have the time to test this on my machine - which I would like to do before merging. Actually, I am looking for somebody to take over ownership of this theme / repo to keep this theme up-2-date and develop it further. Would you be interested to take over? If so, please get in touch at [email protected]. |
|
a later PR seems to partially overlap: #98 |
| <script type="text/javascript" src='{{ "js/index.js" |absURL }}'></script> | ||
| {{ $scriptIcons := resources.Get "js/icons.js" }} | ||
| {{ $scriptIndex := resources.Get "js/index.js" }} | ||
| {{ $js := slice $scriptJquery $scriptIcons $scriptIndex | resources.Concat "js/script.js" | resources.Minify | resources.Fingerprint }} |
There was a problem hiding this comment.
It works.
This basically adds production-quality (minification, fingerprint hash) - that's something we definitely want, although it may be a bit harder to tune the theme js alone. Hugo features used: https://gohugo.io/categories/asset-management/
I'm not sure if there is a simple way to keep the scripts linked separately for development, while automatically using this for publishing the final result. Maybe with some flag in config. Anyways, developers should be capable of finding a simple workaround if needed.
|
To check: what is the minimal Hugo version that supports these features? |
|
@zjedi I dont know the exact minimal version, I use current version 0.109 -> I dont see a problem forcing this version though? |
The pipelines feature seems to have been finished quite some time ago, in https://gohugo.io/news/0.46-relnotes/ The min required version of Hugo is currently ancient 0.41, from five years ago. https://github.com/janraasch/hugo-scroll/blob/master/theme.toml#L27 So yes, it's time for upgrade. |
This PR creates asset for all stylesheets and javascript files. By bundling all files into one and adding a hash value to the filename to support cache busting loading of the page is increased because its faster to load fewer bigger resources - this still keeps the maintainability of having the sources in seperate files.
Further improvements:
I made these optimiziations for my own site while using your theme so I figured the upstream project my use them as well.