Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change '/' to path.sep. #90

Merged
merged 1 commit into from
Apr 22, 2017
Merged

Change '/' to path.sep. #90

merged 1 commit into from
Apr 22, 2017

Conversation

be5invis
Copy link
Collaborator

@be5invis be5invis commented Apr 22, 2017

Potential fix of #92.

@zjhmale
Copy link
Owner

zjhmale commented Apr 22, 2017

@be5invis After playing around our extension on windows7 and windows10, I finally figure out the reason under the hood, it is nothing related to the path separator, one wired thing of VSCode RTS on windows is that, e.g.

let [dpath, module] = uri.split(innerCompilerOptions.src)
// module now is "\\TermLang\\Unify.idr"
let moduleParts = module.split(path.sep)
// moduleParts is ["\\TermLang\\Unify.idr"] which should be ["\\", "TermLang", "Unify.idr"] as expected

which is really confusing, but we can do the split(path.sep) in a normal nodejs prompt on windows.

Anyway, I got a final solusion to fix this without any annoying path splitting and joining.

@be5invis
Copy link
Collaborator Author

@zjhmale this fixes the issue on mu machine that :l ends up with empty string.

@be5invis
Copy link
Collaborator Author

@zjhmale what's the result of path.sep.

@zjhmale
Copy link
Owner

zjhmale commented Apr 22, 2017

@be5invis the result of path.sep is "\"

@zjhmale
Copy link
Owner

zjhmale commented Apr 22, 2017

And #65 is causing when user start an REPL with single Idris file instead of an ipkg project.

@zjhmale
Copy link
Owner

zjhmale commented Apr 22, 2017

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants