This repository has been archived by the owner on Jun 12, 2022. It is now read-only.
fix(redirect): handle redirects explicitly #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zkat
suggested changes
May 22, 2017
index.js
Outdated
| } | ||
|
|
||
| if (req.counter >= req.follow) { | ||
| throw new Error(`maximum redirect reached at: ${uri}`, 'max-redirect') |
There was a problem hiding this comment.
What does this second argument do? The convention so far has been to use a code property on error objects to have single codes that people can use.
There was a problem hiding this comment.
ah, this is my mistake. I'll get the change going thanks! Are there a set of codes to go off of?
There was a problem hiding this comment.
nah. My main suggestion would be to use the convention I've been using for other libraries, so E<SOMECODE> in uppercase. Unix-style.
There was a problem hiding this comment.
Gave it a go - but happy to make changes :)
zkat
approved these changes
May 22, 2017
|
💃 |
|
This has been released as part of |
|
Thanks! 🙌 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #26