Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken preset images, add local images #72

Merged
merged 1 commit into from
Feb 4, 2022

Conversation

tordans
Copy link
Collaborator

@tordans tordans commented Feb 4, 2022

The traffic sign presets are broken ATM. It looks like the files where removed from Wikipedia?

image

I took some images from #69 and added them to the repo. Also two from Wikipedia.

There are also some images for Australia #44 already in the folders (FYI @jakecoppinger).

TODO

  • Find a place to attribute the images; find out hot to attributes them; add attribution.
    • Suggestion: We could maybe add all attributions to the /src/assets/README.md and add a link to there from the details panel (bottom right).

Changes

  • add images from Wikipedia and StreetComplete
  • configure Webpack to serve images (and rename plugin for consistency)
  • fix and add Russian signs

@tordans
Copy link
Collaborator Author

tordans commented Feb 4, 2022

I should also post an 'after' screenshot, right? :-)

image

@tordans tordans mentioned this pull request Feb 4, 2022
@tordans
Copy link
Collaborator Author

tordans commented Feb 4, 2022

TODO: This does not work with the build step, yet. Will look into it…

- add images from Wikipedia and StreetComplete
- configure Webpack to serve images (and rename plugin for consistency)
- fix and add Russian signs
@tordans tordans force-pushed the fix-broken-traffic-signs branch from 4b09eb2 to 255f926 Compare February 4, 2022 14:11
@tordans tordans mentioned this pull request Feb 4, 2022
@zlant zlant merged commit 7acfa71 into zlant:master Feb 4, 2022
@tordans tordans deleted the fix-broken-traffic-signs branch February 4, 2022 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants