Remove most all the boilerplate required to add new trees #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamadden
force-pushed
the
reduce-boilerplate
branch
3 times, most recently
from
967a6b8 to
0314b24
Compare
jamadden
changed the title
|
I think this is ready for review. It's based on #122 so only the final commit is relevant. |
|
There are a handful of cleanups that can be enabled by this and land in a subsequent PR. Most notably, I think the nasty way we're dealing with pickling to make sure we always pickle and unpickle the best implementation can probably be cleaned up. |
test__UUBTree.py is complete and passing on Python 3
And some other small tweaks to the documentation to make cross-references work and things generally look good.
Generate the Python modules and test modules based off a description of the datatype. Several tests that were previously only used for a specific classes are now generalized and added to most trees, such as testing non-compliant keys and testing overflow for bounded values. Also always raise ``OverflowError`` for integer keys/values out of range.
jamadden
force-pushed
the
reduce-boilerplate
branch
from
0314b24 to
2038bcb
Compare
|
Rerun the failing TravisCI jobs as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow on from #122. There were lots of .py files that have to be copied and then search-n-replaced.
This PR uses Python code to programmatically create the correct modules and test modules based on a declarative description of the data types. I'm undecided on leaving the
test_*.pyfiles around. On the one hand, they make zope-testrunner's-mfilter work; on the other hand, they're more near-duplicate files.There are four remaining custom test cases for integer overflow that I'd like to unify into the base cases.
I discovered and fixed a few bugs during the course of this, where test modules had drifted apart and didn't test everything; notably, Bucket and BTree behaved differently since 4.3.2 with regards to KeyError and TypeError in query methods.