-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kill should accept signal names, not just numbers #11
Comments
|
zc.signalhandler is not on GitHub 😢 |
Now it is :) |
Eh, name2signal from zc.signalhandler kind of does the opposite of what I need: converts signal numbers or names to names. I can do getattr(signal, name2signal(arg)), I suppose, to convert it back into a number. |
Uses name2signal() copied and pasted from zc.signalhandler. Adds a test for the previously-untested do_kill().
Gosh, you closed this before I could respond to your comments. Since you had to copy Fortunately, that's still possible with another commit. :-) |
Instead I decided to grab the opportunity to change the output to print the name of the signal being sent, instead of the number. (Hm, there's already another number-to-name conversion function in zdrun.py. Perhaps something could be refactored there. I won't object ;-) |
These three should be equivalent
The text was updated successfully, but these errors were encountered: