Tests leave running processes

[menesis]

After tests are run, two processes are running:

$ ps uxa | grep zdaemon
menesis  13797  0.0  0.2 123868  8848 ?        Ssl  16:43   0:00 /home/menesis/src/zope/zdaemon/python/bin/python ./zdaemon -S /home/menesis/src/zope/zdaemon/src/zdaemon/schema.xml -C conf tail -f data
menesis  13805  0.0  0.2 118208  7800 ?        Ssl  16:43   0:00 /home/menesis/src/zope/zdaemon/python/bin/python /home/menesis/src/zope/zdaemon/src/zdaemon/zdrun.py -d -b 10 -s /tmp/tmpfBlZIn/testsock -x 0,2 -z /home/menesis/src/zope/zdaemon/src/zdaemon/tests /tmp/tmpfBlZIn/donothing.sh

They should be stopped in test cleanup.

[mgedmin]

Also reported at https://bugs.launchpad.net/zdaemon/+bug/1125294

[mgedmin]

I cannot reproduce this any more with current master.

[mgedmin]

My mistake, I fumbled the pgrep command line (hint it's pgrep -f zdaemon, not pgrep zdaemon).

[mgedmin]

For extra bonus points this fix improves test coverage 👍

[mgedmin]

Aaaand the bug is back :/

[mgedmin]

testRunIgnoresParentSignals (zdaemon.tests.testzdrun.ZDaemonTests) leaves one process.

[mgedmin]

Ha ha git bisect claims 37cdbee is responsible.

Therefore I'm pretty sure now that this is non-deterministic.

[mgedmin]

Hahahaa

testRunIgnoresParentSignals does

            # Kill the process.                                                                                                                       
            send_action('exit\n', zdrun_socket)                                                                                                       

Here's how well this works:

29745 sendto(3, "exit\n\n", 6, 0, NULL, 0 <unfinished ...>
29775 accept(3,  <unfinished ...>
29745 <... sendto resumed> )            = 6
29775 <... accept resumed> 0x7ffdaab64e30, 0x7ffdaab64e2c) = 7
29745 shutdown(3, SHUT_WR)              = 0
29745 recvfrom(3,  <unfinished ...>
29775 select(8, [?], [?], [?], {...})   = 1 (left {...})
29775 recvfrom(7, 0x23e28d4, 1000, 0, NULL, NULL) = 6
29775 sendto(7, 0x7f5a44555824, 43, 0, NULL, 0) = 43
29745 <... recvfrom resumed> "Unknown command u'exit'; 'help' "..., 1000, 0, NULL, NULL) = 43