Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop subunit and dependencies. #14

Merged
merged 2 commits into from
May 31, 2017
Merged

Drop subunit and dependencies. #14

merged 2 commits into from
May 31, 2017

Conversation

tseaver
Copy link
Member

@tseaver tseaver commented May 30, 2017

zope.testrunner is dropping the feature, so we don't need to test with it.

zope.testrunner is dropping the feature, so we don't need to test with it.
@tseaver tseaver requested review from mgedmin and hannosch May 30, 2017 17:56
Copy link
Contributor

@hannosch hannosch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Python 2.7 / PyPy 2 tests fail, as they still try to install python-subunit and there are no version pins anymore.

I think this needs to wait until there's a zope.testrunner release without subunit. And than this PR can both drop the version pins and update to the new zope.testrunner version in one go.

@tseaver
Copy link
Member Author

tseaver commented May 30, 2017

@hannosch I've updated the various pins such that bin/test-ztk now passes for me on Linux with Python 2.7. Fingers crossed.

@hannosch
Copy link
Contributor

setuptools is pinned in travis.yml to 28.0 same as it was in the versions file. I think you need to update both places to 33.1.1

@tseaver tseaver force-pushed the drop-subunit-and-deps branch from 95a59e6 to d64986e Compare May 31, 2017 00:14
@tseaver
Copy link
Member Author

tseaver commented May 31, 2017

setuptools is pinned in travis.yml to 28.0 same as it was in the versions file. I think you need to update both places to 33.1.1

D'oh! Of course. tox-travis would help here, maybe?

@tseaver tseaver merged commit f3902d4 into master May 31, 2017
@tseaver tseaver deleted the drop-subunit-and-deps branch May 31, 2017 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants