Redact api and app keys from errors #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ojongerius
reviewed
Oct 24, 2017
request.go
Outdated
| func (client *Client) doJsonRequest(method, api string, | ||
| reqbody, out interface{}) error { | ||
| err := client.doJsonRequestUnsafe(method, api, reqbody, out) |
There was a problem hiding this comment.
A nit picking alternative would be:
if err := client.doJsonRequestUnsafe(method, api, reqbody, out) ; err != nil {
errString := strings.Replace(err.Error(), client.apiKey, "redacted", -1)
errString = strings.Replace(errString, client.appKey, "redacted", -1)
return fmt.Errorf(errString)
}There was a problem hiding this comment.
Will update this ^
request.go
Outdated
|
|
||
| // doJsonRequestUnsafe is the simplest type of request: a method on a URI that returns | ||
| // some JSON result which we unmarshal into the passed interface. | ||
| func (client *Client) doJsonRequestUnsafe(method, api string, |
There was a problem hiding this comment.
Would doJsonRequestUnredacted be a more informative name?
ojongerius
reviewed
Oct 24, 2017
ojongerius
approved these changes
Nov 12, 2017
* Unset api / app keys resulted in redacted being inserted between each letter of the error string. This will ensure only actually set (rather than empty string) api / app keys are redacted.
|
Rebased off master to resolve conflicts, also added the tests you mentioned @ojongerius. What do you think? :) |
|
Awesome, thanks for adding the tests! LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #76.
I don't know if this is the right way to fix this but I took a stab at it.