Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change http-method GET to POST on api.Screenboard#share #128

Merged
merged 1 commit into from
Nov 14, 2017

Conversation

haohcraft
Copy link

For the CSRF concern, we have changed GET to POST for screenboard:share API.

@nyanshak
Copy link
Collaborator

What's the CSRF concern here? Is there an issue, datadog support page, or some other place describing it?

@haohcraft
Copy link
Author

Since this get endpoint is to mute the sharable state, it's better to use POST instead.

@ojongerius
Copy link
Collaborator

@haohcraft thanks for the PR! According to the docs at https://docs.datadoghq.com/api/?lang=console#screenboards sharing takes a GET, creation a POST and updating a PUT, -as you would expect from a REST endpoint.

Could you please elaborate on what gave you the motivation to make this change? I'm interested to understand your concern here.

@haohcraft
Copy link
Author

According to https://docs.datadoghq.com/api/?lang=console#screenboards-share, it should be a POST now.

@ojongerius ojongerius merged commit fb5f8a6 into zorkian:master Nov 14, 2017
@ojongerius
Copy link
Collaborator

Thanks @haohcraft!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants