-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add integrations/pagerduty API Support #144
Conversation
…e struct naming format from req* to *Request
integrations.go
Outdated
* | ||
* Please see the included LICENSE file for licensing information. | ||
* | ||
* Copyright 2013 by authors and contributors. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please update the year to 2018?
Schedules []string `json:"schedules"` | ||
APIToken *string `json:"api_token"` | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please add comments? See https://blog.golang.org/godoc-documenting-go-code
integrations.go
Outdated
return &out, nil | ||
} | ||
|
||
// DeleteIntegrationPD remove the PD Integration from the system. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"removes"
Thanks for this!
Would you be willing to raise an issue at Datadog, possibly linking this PR in, that looks like a bug to me. |
Thanks for the review! I'm not sure what's the best place to raise this issue so I've raised it at datadog/documentation. It should at minimum be documented on Datadog itself. |
@ojongerius @yfronto What would be the next steps for this PR? |
Thanks @rlhh! 🙇 |
Datadog has recently introduced APIs to support CRUD operations for integrations(https://docs.datadoghq.com/api/?lang=bash#integrations).
This PR adds support for CRUD operations on the Pagerduty Integration https://docs.datadoghq.com/api/?lang=bash#pagerduty.
Things to note: