Add AWS Integration #162
Add AWS Integration #162
Conversation
ghost
self-assigned this
integrations.go
Outdated
|
|
||
| var awsIntegrations []IntegrationAWSAccount | ||
|
|
||
| for _, account := range response.Accounts { |
There was a problem hiding this comment.
Is the loop here necessary? Couldn't we just return the response object?
There was a problem hiding this comment.
AFAICT
line 174 until 178 can be replaced with:
return &response.Accounts, nil
There was a problem hiding this comment.
This has been updated @ojongerius 👍
|
The code in I did experiment to see if it was possible to perform a GET request for a specific AWS integration; however, it looks like that's not exposed. |
|
I opened a support ticket to Datadog and confirmed that the API for the AWS integration does not yet support a PUT update action. So we're good on that. |
|
@yfronto Can you provide some feedback on this PR? |
integrations.go
Outdated
|
|
||
| var awsIntegrations []IntegrationAWSAccount | ||
|
|
||
| for _, account := range response.Accounts { |
There was a problem hiding this comment.
AFAICT
line 174 until 178 can be replaced with:
return &response.Accounts, nil
|
Released in v2.11.0 |
PR Details
Notes:
Updatefunction.Questions:
{'external_id': '123456789'}. I am currently marshalling this to theIntegrationAWSAccountCreateResponsestruct. It appearsexternal_idis never needed again in further API calls so perhaps I should just return anerrorfrom theCreateIntegrationAWSfunction and delete this struct?GetIntegrationAWSByAccountor similar function to prevent a consumer of the client having to loop through the results of theGetIntegrationAWSfunction?